From 7d2a7a56267b8444ba1756a9a6a52157fd931758 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=D0=A0=D1=83=D1=81=D0=BB=D0=B0=D0=BD=20=D0=98=D0=B6=D0=B1?= =?utf8?q?=D1=83=D0=BB=D0=B0=D1=82=D0=BE=D0=B2?= Date: Thu, 17 Mar 2016 20:07:33 +0000 Subject: [PATCH] GDK W32: Don't move iconic windows Using UpdateLayeredWindow() on iconic windows brings them *back* from their iconic (minimized) state. That is bad. As a precaution, also don't use SetWindowPos() on iconic windows. This means that iconic windows can't be moved. That is fixable by using SetWindowPlacement(), but there is no pressing need to do so, as there are very few cases when windows need to be moved while minimized. https://bugzilla.gnome.org/show_bug.cgi?id=763835 --- gdk/win32/gdkwindow-win32.c | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/gdk/win32/gdkwindow-win32.c b/gdk/win32/gdkwindow-win32.c index d112d32d00..bedf5351ea 100644 --- a/gdk/win32/gdkwindow-win32.c +++ b/gdk/win32/gdkwindow-win32.c @@ -224,16 +224,24 @@ static void gdk_win32_window_apply_queued_move_resize (GdkWindow *window, RECT window_rect) { - GDK_NOTE (EVENTS, g_print ("Setting window position ... ")); + if (!IsIconic (GDK_WINDOW_HWND (window))) + { + GDK_NOTE (EVENTS, g_print ("Setting window position ... ")); + + API_CALL (SetWindowPos, (GDK_WINDOW_HWND (window), + SWP_NOZORDER_SPECIFIED, + window_rect.left, window_rect.top, + window_rect.right - window_rect.left, + window_rect.bottom - window_rect.top, + SWP_NOACTIVATE | SWP_NOZORDER | SWP_NOREDRAW)); - API_CALL (SetWindowPos, (GDK_WINDOW_HWND (window), - SWP_NOZORDER_SPECIFIED, - window_rect.left, window_rect.top, - window_rect.right - window_rect.left, - window_rect.bottom - window_rect.top, - SWP_NOACTIVATE | SWP_NOZORDER | SWP_NOREDRAW)); + GDK_NOTE (EVENTS, g_print (" ... set window position\n")); + + return; + } - GDK_NOTE (EVENTS, g_print (" ... set window position\n")); + /* Don't move iconic windows */ + /* TODO: use SetWindowPlacement() to change non-minimized window position */ } static gboolean @@ -349,6 +357,14 @@ gdk_win32_window_end_paint (GdkWindow *window) cairo_surface_flush (impl->cache_surface); hdc = cairo_win32_surface_get_dc (impl->cache_surface); + /* Don't use UpdateLayeredWindow on minimized windows */ + if (IsIconic (GDK_WINDOW_HWND (window))) + { + gdk_win32_window_apply_queued_move_resize (window, window_rect); + + return; + } + /* Move, resize and redraw layered window in one call */ API_CALL (UpdateLayeredWindow, (GDK_WINDOW_HWND (window), NULL, &window_position, &window_size, -- 2.30.2